fix(trace): add more opcode handlings #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noel2004
approved these changes
Jul 24, 2022
There was a problem hiding this comment.
LGTM. Just a little worry about the size of trace for contract code maybe large, and we may have recorded duplicated code in the block trace. Maybe it would be better to record all codes being accessed in "storageTrace" block or something similar? (It can be left as an optimization later)
|
gonna merge first and run sushi-test. will revert the changes for |
|
update: The sushi test (which involves |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
according to https://github.com/scroll-tech/zkevm-circuits/blob/scroll-dev-0714/bus-mapping/src/circuit_input_builder/access.rs#L114
related PR: scroll-tech/scroll-prover#29
question
In fact I don't know why I have
traceCallerforCALL&CALLCODE, but looks like we should usetraceContractAccount?